Markus Armbruster
a109de948b
TREATIES has issues:
* Treaties can cover attack, assault, paradrop, board, lboard, fire,
build (s|p|l|n) and enlist, but not bomb, launch, torpedo and
enlistment centers.
* Usability is very poor. While a treaty is in effect, every player
action that violates a treaty condition triggers a prompt like this:
This action is in contravention of treaty #0 (with Curmudgeon)
Do you wish to go ahead anyway? [yn]
If you decline, the action is not executed. If you accept, it is.
In both cases, your decision is reported in the news.
You cannot get rid of these prompts until the treaty expires.
* Virtually nobody uses them.
* Virtually unused code is buggy code. There is at least one race
condition: multifire() reads the firing sector, ship or land unit
before the treaty prompt, and writes it back after, triggering a
generation oops. Any updates made by other threads while trechk()
waits for input are wiped out, triggering a seqno mismatch oops.
* The treaty prompts could confuse smart clients that aren't prepared
for them. WinACE isn't, but is reported to work anyway at least
common usage. Ron Koenderink (the WinACE maintainer) suspects there
could be a few situations where it will fail.
This feature is not earning its keep. Remove it. Drop command
treaty, consider treaty, offer treaty, xdump treaty, reject treaties.
Output of accept changed, obviously.
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
23 lines
912 B
Perl
23 lines
912 B
Perl
.TH Command ACCEPT
|
|
.NA accept "Find out who's accepting what communications from whom"
|
|
.LV Expert
|
|
.SY "accept [country]"
|
|
The accept command allows you to find out the communications status of
|
|
a country. With no argument, accept prints your status. With an argument,
|
|
it prints the acceptance status of the specified country.
|
|
.s1
|
|
.EX "accept 7"
|
|
.nf
|
|
Temekula Acceptance Status Report Sat Jan 11 17:02:53 2014
|
|
|
|
Acceptance status his theirs
|
|
tel anno loan tel anno loan
|
|
1) Gobu YES YES YES YES YES YES
|
|
2) Spectre YES YES YES YES YES YES
|
|
3) Rohan YES YES YES YES YES YES
|
|
4) Sioux YES YES YES YES YES YES
|
|
5) Tom_Servo YES YES YES YES YES YES
|
|
6) Horgoth YES YES YES YES YES YES
|
|
.fi
|
|
.s1
|
|
.SA "telegram, announce, read, wire, reject, Diplomacy, Communication"
|