empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
empserver/include
History
Markus Armbruster 439f111f98 Remove option SLOW_WAR 
SLOW_WAR has issues:

* The check whether the attacker old-owns the attacked sector is
  broken, because att_abort() uses sect.sct_oldown uninitialized.

  Spotted by the Clang Static Analyzer.

* Its implementation in setrel() is somewhat scary.  It's actually
  okay, because that part of setrel() only runs within decl().  Other
  callers don't reach it: update_main() because player->god != 0
  there, and the rest because they never pass a rel < HOSTILE.

* Documentation is a bit vague.

SLOW_WAR hasn't been used in a public game in years.  Fixing it is not
worth it, so remove it instead.
2011-02-13 15:59:49 +01:00
..
budg.h Update copyright notice 2010-01-19 08:40:17 +01:00
com.h Update copyright notice 2010-01-19 08:40:17 +01:00
combat.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
commands.h Update copyright notice 2010-01-19 08:40:17 +01:00
commodity.h Update copyright notice 2010-01-19 08:40:17 +01:00
damage.h Update copyright notice 2010-01-19 08:40:17 +01:00
distribute.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
econfig-spec.h Remove option SLOW_WAR 2011-02-13 15:59:49 +01:00
empio.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
empobj.h Update copyright notice 2010-01-19 08:40:17 +01:00
empthread.h Update copyright notice 2010-01-19 08:40:17 +01:00
file.h Update copyright notice 2010-01-19 08:40:17 +01:00
game.h Update copyright notice 2010-01-19 08:40:17 +01:00
ioqueue.h Change ioq_dequeue() to return void 2010-08-29 11:38:02 +02:00
item.h Coding style fixes, mostly indentation and whitespace 2010-06-20 18:36:38 +02:00
journal.h Update copyright notice 2010-01-19 08:40:17 +01:00
land.h Clean up output destinations in attack code 2010-07-24 11:28:33 +02:00
loan.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
lost.h Coding style fixes, mostly indentation and whitespace 2010-06-20 18:36:38 +02:00
lwp.h Coding style fixes, mostly indentation and whitespace 2010-06-20 18:36:38 +02:00
map.h Update copyright notice 2010-01-19 08:40:17 +01:00
match.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
misc.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
mission.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
nat.h Remove option SLOW_WAR 2011-02-13 15:59:49 +01:00
news.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
nsc.h Break long lines more tastefully 2010-06-20 18:36:44 +02:00
nuke.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
optlist.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
path.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
plague.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
plane.h Factor common plane damage code into ac_damage_plane() 2010-07-18 08:36:19 +02:00
player.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
power.h Update copyright notice 2010-01-19 08:40:17 +01:00
product.h Update copyright notice 2010-01-19 08:40:17 +01:00
proto.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
prototypes.h Remove unused plurize() 2011-01-09 15:21:39 +01:00
queue.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
retreat.h Convert tab after #define to space 2010-06-20 18:38:54 +02:00
sect.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
server.h Update copyright notice 2010-01-19 08:40:17 +01:00
service.h Update copyright notice 2010-01-19 08:40:17 +01:00
ship.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
tel.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
trade.h Don't write garbage to unused trade destination in trade file 2010-07-25 17:48:53 +02:00
treaty.h Tidy up whitespace in macro replacement lists 2010-06-20 18:39:31 +02:00
types.h Update copyright notice 2010-01-19 08:40:17 +01:00
unit.h Update copyright notice 2010-01-19 08:40:17 +01:00
update.h Update copyright notice 2010-01-19 08:40:17 +01:00
version.h Update copyright notice 2010-01-19 08:40:17 +01:00
xdump.h Update copyright notice 2010-01-19 08:40:17 +01:00
xy.h Update copyright notice 2010-01-19 08:40:17 +01:00