struct trdstr members trd_x, trd_y are used only for teleporting trades. For others, trad() wrote garbage coordinates to the trade file. They weren't used except by xdump. Fortunately, even there they're visible only to deities. Write invalid coordinates instead. Do that in set() as well, so that coordinates are valid only when we have a teleport destination. Spotted by the Clang Static Analyzer.
71 lines
2.3 KiB
C
71 lines
2.3 KiB
C
/*
|
|
* Empire - A multi-player, client/server Internet based war game.
|
|
* Copyright (C) 1986-2010, Dave Pare, Jeff Bailey, Thomas Ruschak,
|
|
* Ken Stevens, Steve McClure
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
* ---
|
|
*
|
|
* See files README, COPYING and CREDITS in the root of the source
|
|
* tree for related information and legal notices. It is expected
|
|
* that future projects/authors will amend these files as needed.
|
|
*
|
|
* ---
|
|
*
|
|
* trade.h: Definitions for trading units/ships/planes in a time delay
|
|
* system
|
|
*
|
|
* Known contributors to this file:
|
|
* Dave Pare
|
|
* Pat Loney, 1992
|
|
* Steve McClure, 1996
|
|
*/
|
|
|
|
#ifndef TRADE_H
|
|
#define TRADE_H
|
|
|
|
#include <time.h>
|
|
#include "types.h"
|
|
|
|
struct trdstr {
|
|
/* initial part must match struct empobj */
|
|
signed ef_type: 8;
|
|
unsigned trd_seqno: 12;
|
|
unsigned trd_generation: 12;
|
|
int trd_uid;
|
|
time_t trd_timestamp;
|
|
natid trd_owner;
|
|
/* end of part matching struct empobj */
|
|
short trd_type;
|
|
int trd_unitid;
|
|
long trd_price;
|
|
int trd_maxbidder;
|
|
time_t trd_markettime;
|
|
coord trd_x; /* destination for teleporting trade */
|
|
coord trd_y;
|
|
};
|
|
|
|
extern int trade_check_ok(struct trdstr *, union empobj_storage *);
|
|
extern int trade_check_item_ok(union empobj_storage *);
|
|
extern char *trade_nameof(struct trdstr *, union empobj_storage *);
|
|
extern int trade_desc(struct trdstr *, union empobj_storage *);
|
|
extern int trade_getitem(struct trdstr *, union empobj_storage *);
|
|
|
|
#define gettrade(n, p) ef_read(EF_TRADE, (n), (p))
|
|
#define puttrade(n, p) ef_write(EF_TRADE, (n), (p))
|
|
#define gettradep(n) ((struct trdstr *)ef_ptr(EF_TRADE, (n)))
|
|
|
|
#endif
|