empserver/tests/navi-march-test
Markus Armbruster 69c99a0f29 march: Require all land units to start in the same sector
The capability to march land units spread over several sectors is
obscure and rarely useful.  Accidental use is probably more frequent
than intentional use.  Issues:

* Interactive prompts show only the leader's position, and give no
  clue that some land units are actually elsewhere.

* Path finding is supported only when all marching land units are in
  the same sector.

* In each step, the bmap is updated for the leader's radar.  The bmap
  is not updated around other marching land units.  Already odd when
  all units are in the leader's sector, and odder still when some are
  elsewhere.

* Interdiction becomes rather complex.  For each movement, every
  sector entered is interdicted independently.  This means the same
  ship, land unit or plane can interdict multiple times.  Interdiction
  order depends on the order the code examines land units. which the
  player can control.  This is all pretty much undocumented.

* Complicates the code and its maintenance.  Multiplies the number of
  test cases needed to cover march.

I feel we're better off without this feature.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
2015-02-28 16:13:14 +01:00

26 lines
416 B
Bash
Executable file

#!/bin/sh -e
# navigate and march test for Empire
if [ $# -ne 1 ]
then echo "Usage: $0 SRCDIR" >&2; exit 1
fi
srcdir="$1"
. "$srcdir"/tests/test-common.sh
create_sandbox
cat >>$econfig <<EOF
WORLD_X 32
WORLD_Y 16
MARKET 1
EOF
customize big-city
# TODO cover scattered navigate
# TODO cover RAILWAYS 0
begin_test "$srcdir"/tests/navi-march/setup-POGO
feed_dir "$srcdir"/tests/navi-march
end_test
cmp_logs_xdump