Markus Armbruster
a109de948b
TREATIES has issues:
* Treaties can cover attack, assault, paradrop, board, lboard, fire,
build (s|p|l|n) and enlist, but not bomb, launch, torpedo and
enlistment centers.
* Usability is very poor. While a treaty is in effect, every player
action that violates a treaty condition triggers a prompt like this:
This action is in contravention of treaty #0 (with Curmudgeon)
Do you wish to go ahead anyway? [yn]
If you decline, the action is not executed. If you accept, it is.
In both cases, your decision is reported in the news.
You cannot get rid of these prompts until the treaty expires.
* Virtually nobody uses them.
* Virtually unused code is buggy code. There is at least one race
condition: multifire() reads the firing sector, ship or land unit
before the treaty prompt, and writes it back after, triggering a
generation oops. Any updates made by other threads while trechk()
waits for input are wiped out, triggering a seqno mismatch oops.
* The treaty prompts could confuse smart clients that aren't prepared
for them. WinACE isn't, but is reported to work anyway at least
common usage. Ron Koenderink (the WinACE maintainer) suspects there
could be a few situations where it will fail.
This feature is not earning its keep. Remove it. Drop command
treaty, consider treaty, offer treaty, xdump treaty, reject treaties.
Output of accept changed, obviously.
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
103 lines
2.9 KiB
C
103 lines
2.9 KiB
C
/*
|
|
* Empire - A multi-player, client/server Internet based war game.
|
|
* Copyright (C) 1986-2014, Dave Pare, Jeff Bailey, Thomas Ruschak,
|
|
* Ken Stevens, Steve McClure, Markus Armbruster
|
|
*
|
|
* Empire is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* ---
|
|
*
|
|
* See files README, COPYING and CREDITS in the root of the source
|
|
* tree for related information and legal notices. It is expected
|
|
* that future projects/authors will amend these files as needed.
|
|
*
|
|
* ---
|
|
*
|
|
* empobj.h: General empire objects.
|
|
*
|
|
* Known contributors to this file:
|
|
* Ron Koenderink, 2006
|
|
* Markus Armbruster, 2006-2011
|
|
*/
|
|
|
|
#ifndef EMPOBJ_H
|
|
#define EMPOBJ_H
|
|
|
|
#include "commodity.h"
|
|
#include "game.h"
|
|
#include "land.h"
|
|
#include "loan.h"
|
|
#include "lost.h"
|
|
#include "nat.h"
|
|
#include "nuke.h"
|
|
#include "plane.h"
|
|
#include "sect.h"
|
|
#include "ship.h"
|
|
#include "trade.h"
|
|
#include "types.h"
|
|
|
|
struct empobj {
|
|
/*
|
|
* initial part must match struct emptypedstr
|
|
* valid if EFF_TYPED is set in table's flags
|
|
*/
|
|
signed ef_type: 8;
|
|
unsigned seqno: 12;
|
|
unsigned generation: 12;
|
|
int uid;
|
|
time_t timestamp;
|
|
/* end of part matching struct emptypedstr */
|
|
natid own; /* valid if EFF_OWNER is in table's flags */
|
|
coord x; /* valid if EFF_XY is in table's flags */
|
|
coord y; /* valid if EFF_XY is in table's flags */
|
|
/* remaining are valid for sectors and units */
|
|
signed char type;
|
|
signed char effic;
|
|
signed char mobil;
|
|
unsigned char off;
|
|
/* remaining are valid for units */
|
|
short tech;
|
|
char group; /* valid if EFF_GROUP is in table's flags */
|
|
coord opx, opy;
|
|
short mission;
|
|
short radius;
|
|
};
|
|
|
|
union empobj_storage {
|
|
struct empobj gen;
|
|
struct comstr comm;
|
|
struct gamestr game;
|
|
struct lndstr land;
|
|
struct lonstr loan;
|
|
struct loststr lost;
|
|
struct natstr nat;
|
|
struct nukstr nuke;
|
|
struct plnstr plane;
|
|
struct realmstr realm;
|
|
struct sctstr sect;
|
|
struct shpstr ship;
|
|
struct trdstr trade;
|
|
};
|
|
|
|
struct empobj_chr;
|
|
|
|
#define get_empobj(type, n, p) ef_read((type), (n), (p))
|
|
#define put_empobj(type, n, p) ef_write((type), (n), (p))
|
|
#define get_empobjp(type, n) ((struct empobj *)ef_ptr((type), (n)))
|
|
|
|
extern char *empobj_chr_name(struct empobj *gp);
|
|
extern int get_empobj_mob_max(int type);
|
|
extern int empobj_in_use(int, void *);
|
|
|
|
#endif
|