Markus Armbruster
a109de948b
TREATIES has issues:
* Treaties can cover attack, assault, paradrop, board, lboard, fire,
build (s|p|l|n) and enlist, but not bomb, launch, torpedo and
enlistment centers.
* Usability is very poor. While a treaty is in effect, every player
action that violates a treaty condition triggers a prompt like this:
This action is in contravention of treaty #0 (with Curmudgeon)
Do you wish to go ahead anyway? [yn]
If you decline, the action is not executed. If you accept, it is.
In both cases, your decision is reported in the news.
You cannot get rid of these prompts until the treaty expires.
* Virtually nobody uses them.
* Virtually unused code is buggy code. There is at least one race
condition: multifire() reads the firing sector, ship or land unit
before the treaty prompt, and writes it back after, triggering a
generation oops. Any updates made by other threads while trechk()
waits for input are wiped out, triggering a seqno mismatch oops.
* The treaty prompts could confuse smart clients that aren't prepared
for them. WinACE isn't, but is reported to work anyway at least
common usage. Ron Koenderink (the WinACE maintainer) suspects there
could be a few situations where it will fail.
This feature is not earning its keep. Remove it. Drop command
treaty, consider treaty, offer treaty, xdump treaty, reject treaties.
Output of accept changed, obviously.
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
117 lines
3 KiB
C
117 lines
3 KiB
C
/*
|
|
* Empire - A multi-player, client/server Internet based war game.
|
|
* Copyright (C) 1986-2014, Dave Pare, Jeff Bailey, Thomas Ruschak,
|
|
* Ken Stevens, Steve McClure, Markus Armbruster
|
|
*
|
|
* Empire is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* ---
|
|
*
|
|
* See files README, COPYING and CREDITS in the root of the source
|
|
* tree for related information and legal notices. It is expected
|
|
* that future projects/authors will amend these files as needed.
|
|
*
|
|
* ---
|
|
*
|
|
* empobj.c: Common functions on struct empobj and
|
|
* union empobj_storage
|
|
*
|
|
* Known contributors to this file:
|
|
* Ron Koenderink, 2006
|
|
* Markus Armbruster, 2006-2008
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "empobj.h"
|
|
#include "file.h"
|
|
#include "news.h"
|
|
#include "optlist.h"
|
|
#include "product.h"
|
|
|
|
char *
|
|
empobj_chr_name(struct empobj *gp)
|
|
{
|
|
switch (gp->ef_type) {
|
|
case EF_LAND:
|
|
return lchr[(int)gp->type].l_name;
|
|
case EF_SHIP:
|
|
return mchr[(int)gp->type].m_name;
|
|
case EF_PLANE:
|
|
return plchr[(int)gp->type].pl_name;
|
|
case EF_NUKE:
|
|
return nchr[(int)gp->type].n_name;
|
|
case EF_SECTOR:
|
|
return dchr[(int)gp->type].d_name;
|
|
}
|
|
CANT_REACH();
|
|
return "The Beast";
|
|
}
|
|
|
|
int
|
|
get_empobj_mob_max(int type)
|
|
{
|
|
switch (type) {
|
|
case EF_SHIP:
|
|
return ship_mob_max;
|
|
case EF_LAND:
|
|
return land_mob_max;
|
|
case EF_PLANE:
|
|
return plane_mob_max;
|
|
case EF_SECTOR:
|
|
return sect_mob_max;
|
|
}
|
|
CANT_REACH();
|
|
return -1;
|
|
}
|
|
|
|
int
|
|
empobj_in_use(int type, void *p)
|
|
{
|
|
switch (type) {
|
|
case EF_SHIP:
|
|
case EF_PLANE:
|
|
case EF_LAND:
|
|
case EF_NUKE:
|
|
case EF_TRADE:
|
|
case EF_COMM:
|
|
case EF_LOST:
|
|
return ((struct empobj *)p)->own != 0;
|
|
case EF_NATION:
|
|
case EF_COUNTRY:
|
|
return ((struct natstr *)p)->nat_stat != STAT_UNUSED;
|
|
case EF_NEWS:
|
|
return ((struct nwsstr *)p)->nws_vrb != 0;
|
|
case EF_LOAN:
|
|
return ((struct lonstr *)p)->l_status != LS_FREE;
|
|
case EF_REALM:
|
|
return empobj_in_use(EF_NATION,
|
|
ef_ptr(EF_NATION,
|
|
((struct realmstr *)p)->r_cnum));
|
|
case EF_PRODUCT:
|
|
return ((struct pchrstr *)p)->p_sname[0];
|
|
case EF_SHIP_CHR:
|
|
return ((struct mchrstr *)p)->m_name[0];
|
|
case EF_PLANE_CHR:
|
|
return ((struct plchrstr *)p)->pl_name[0];
|
|
case EF_LAND_CHR:
|
|
return ((struct lchrstr *)p)->l_name[0];
|
|
case EF_NUKE_CHR:
|
|
return ((struct nchrstr *)p)->n_name[0];
|
|
case EF_NEWS_CHR:
|
|
return ((struct rptstr *)p)->r_newspage != 0;
|
|
default:
|
|
return 1;
|
|
}
|
|
}
|