Markus Armbruster
a109de948b
TREATIES has issues:
* Treaties can cover attack, assault, paradrop, board, lboard, fire,
build (s|p|l|n) and enlist, but not bomb, launch, torpedo and
enlistment centers.
* Usability is very poor. While a treaty is in effect, every player
action that violates a treaty condition triggers a prompt like this:
This action is in contravention of treaty #0 (with Curmudgeon)
Do you wish to go ahead anyway? [yn]
If you decline, the action is not executed. If you accept, it is.
In both cases, your decision is reported in the news.
You cannot get rid of these prompts until the treaty expires.
* Virtually nobody uses them.
* Virtually unused code is buggy code. There is at least one race
condition: multifire() reads the firing sector, ship or land unit
before the treaty prompt, and writes it back after, triggering a
generation oops. Any updates made by other threads while trechk()
waits for input are wiped out, triggering a seqno mismatch oops.
* The treaty prompts could confuse smart clients that aren't prepared
for them. WinACE isn't, but is reported to work anyway at least
common usage. Ron Koenderink (the WinACE maintainer) suspects there
could be a few situations where it will fail.
This feature is not earning its keep. Remove it. Drop command
treaty, consider treaty, offer treaty, xdump treaty, reject treaties.
Output of accept changed, obviously.
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
55 lines
1 KiB
Text
55 lines
1 KiB
Text
break
|
|
expl c 0,0 1 uh
|
|
desi 1,-1 +
|
|
mov c 0,0 205 uh
|
|
desi 1,-1 g
|
|
cen *
|
|
xdump meta sect
|
|
xdump meta ship
|
|
xdump meta plane
|
|
xdump meta land
|
|
xdump meta nuke
|
|
xdump meta news
|
|
__cmd added -1 0 0
|
|
xdump meta trade
|
|
xdump meta nat
|
|
xdump meta loan
|
|
xdump meta commodity
|
|
xdump meta lost
|
|
xdump meta realm
|
|
xdump meta game
|
|
xdump meta item
|
|
xdump meta product
|
|
xdump meta sect-chr
|
|
xdump meta ship-chr
|
|
xdump meta plane-chr
|
|
xdump meta land-chr
|
|
xdump meta nuke-chr
|
|
xdump meta news-chr
|
|
xdump meta infrastructure
|
|
xdump meta updates
|
|
xdump meta table
|
|
xdump meta version
|
|
xdump meta meta
|
|
xdump meta sector
|
|
xdump meta agreement-status
|
|
xdump meta land-chr-flags
|
|
xdump meta level
|
|
xdump meta meta-flags
|
|
xdump meta meta-type
|
|
xdump meta missions
|
|
xdump meta nation-flags
|
|
xdump meta nation-rejects
|
|
xdump meta nation-relationships
|
|
xdump meta nation-status
|
|
xdump meta nuke-chr-flags
|
|
xdump meta packing
|
|
xdump meta page-headings
|
|
xdump meta plague-stages
|
|
xdump meta plane-chr-flags
|
|
xdump meta plane-flags
|
|
xdump meta resources
|
|
xdump meta retreat-flags
|
|
xdump meta ship-chr-flags
|
|
__cmd added -1 0 0
|
|
xdump meta country
|