Markus Armbruster
a109de948b
TREATIES has issues:
* Treaties can cover attack, assault, paradrop, board, lboard, fire,
build (s|p|l|n) and enlist, but not bomb, launch, torpedo and
enlistment centers.
* Usability is very poor. While a treaty is in effect, every player
action that violates a treaty condition triggers a prompt like this:
This action is in contravention of treaty #0 (with Curmudgeon)
Do you wish to go ahead anyway? [yn]
If you decline, the action is not executed. If you accept, it is.
In both cases, your decision is reported in the news.
You cannot get rid of these prompts until the treaty expires.
* Virtually nobody uses them.
* Virtually unused code is buggy code. There is at least one race
condition: multifire() reads the firing sector, ship or land unit
before the treaty prompt, and writes it back after, triggering a
generation oops. Any updates made by other threads while trechk()
waits for input are wiped out, triggering a seqno mismatch oops.
* The treaty prompts could confuse smart clients that aren't prepared
for them. WinACE isn't, but is reported to work anyway at least
common usage. Ron Koenderink (the WinACE maintainer) suspects there
could be a few situations where it will fail.
This feature is not earning its keep. Remove it. Drop command
treaty, consider treaty, offer treaty, xdump treaty, reject treaties.
Output of accept changed, obviously.
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
49 lines
862 B
Text
49 lines
862 B
Text
xdump sect 0,0
|
|
xdump ship *
|
|
xdump plane *
|
|
xdump land *
|
|
xdump nuke *
|
|
xdump news *
|
|
__cmd added -1 0 0
|
|
xdump trade *
|
|
xdump nat *
|
|
xdump loan *
|
|
xdump commodity *
|
|
xdump lost *
|
|
xdump realm 0
|
|
xdump game *
|
|
xdump item *
|
|
xdump product *
|
|
xdump sect-chr *
|
|
xdump ship-chr *
|
|
xdump plane-chr *
|
|
xdump land-chr *
|
|
xdump nuke-chr *
|
|
xdump news-chr *
|
|
xdump infrastructure *
|
|
xdump updates *
|
|
xdump table *
|
|
xdump version *
|
|
xdump meta *
|
|
xdump sector *
|
|
xdump agreement-status *
|
|
xdump land-chr-flags *
|
|
xdump level *
|
|
xdump meta-flags *
|
|
xdump meta-type *
|
|
xdump missions *
|
|
xdump nation-flags *
|
|
xdump nation-rejects *
|
|
xdump nation-relationships *
|
|
xdump nation-status *
|
|
xdump nuke-chr-flags *
|
|
xdump packing *
|
|
xdump page-headings *
|
|
xdump plague-stages *
|
|
xdump plane-chr-flags *
|
|
xdump plane-flags *
|
|
xdump resources *
|
|
xdump retreat-flags *
|
|
xdump ship-chr-flags *
|
|
__cmd added -1 0 0
|
|
xdump country *
|