Markus Armbruster
a109de948b
TREATIES has issues:
* Treaties can cover attack, assault, paradrop, board, lboard, fire,
build (s|p|l|n) and enlist, but not bomb, launch, torpedo and
enlistment centers.
* Usability is very poor. While a treaty is in effect, every player
action that violates a treaty condition triggers a prompt like this:
This action is in contravention of treaty #0 (with Curmudgeon)
Do you wish to go ahead anyway? [yn]
If you decline, the action is not executed. If you accept, it is.
In both cases, your decision is reported in the news.
You cannot get rid of these prompts until the treaty expires.
* Virtually nobody uses them.
* Virtually unused code is buggy code. There is at least one race
condition: multifire() reads the firing sector, ship or land unit
before the treaty prompt, and writes it back after, triggering a
generation oops. Any updates made by other threads while trechk()
waits for input are wiped out, triggering a seqno mismatch oops.
* The treaty prompts could confuse smart clients that aren't prepared
for them. WinACE isn't, but is reported to work anyway at least
common usage. Ron Koenderink (the WinACE maintainer) suspects there
could be a few situations where it will fail.
This feature is not earning its keep. Remove it. Drop command
treaty, consider treaty, offer treaty, xdump treaty, reject treaties.
Output of accept changed, obviously.
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
106 lines
2.7 KiB
C
106 lines
2.7 KiB
C
/*
|
|
* Empire - A multi-player, client/server Internet based war game.
|
|
* Copyright (C) 1986-2014, Dave Pare, Jeff Bailey, Thomas Ruschak,
|
|
* Ken Stevens, Steve McClure, Markus Armbruster
|
|
*
|
|
* Empire is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* ---
|
|
*
|
|
* See files README, COPYING and CREDITS in the root of the source
|
|
* tree for related information and legal notices. It is expected
|
|
* that future projects/authors will amend these files as needed.
|
|
*
|
|
* ---
|
|
*
|
|
* reje.c: Refuse telegrams/annos/loans from countries
|
|
*
|
|
* Known contributors to this file:
|
|
*
|
|
*/
|
|
|
|
#include <config.h>
|
|
|
|
#include "commands.h"
|
|
|
|
int
|
|
reje(void)
|
|
{
|
|
char *p;
|
|
int rel;
|
|
int do_undo;
|
|
struct natstr nat;
|
|
struct nstr_item ni;
|
|
char buf[1024];
|
|
|
|
if (!(p = getstarg(player->argp[1], "reject or accept? ", buf)))
|
|
return RET_SYN;
|
|
switch (*p) {
|
|
case 'r':
|
|
do_undo = 1;
|
|
break;
|
|
case 'a':
|
|
do_undo = 0;
|
|
break;
|
|
default:
|
|
pr("That's not one of the choices!\n");
|
|
return RET_SYN;
|
|
}
|
|
p = getstarg(player->argp[2],
|
|
"mail, loans, or announcements? ", buf);
|
|
if (!p)
|
|
return RET_SYN;
|
|
switch (*p) {
|
|
case 'a':
|
|
rel = REJ_ANNO;
|
|
break;
|
|
case 'l':
|
|
rel = REJ_LOAN;
|
|
break;
|
|
case 'm':
|
|
rel = REJ_TELE;
|
|
break;
|
|
default:
|
|
pr("That's not one of the choices!\n");
|
|
return RET_SYN;
|
|
}
|
|
if (!snxtitem(&ni, EF_NATION, player->argp[3], NULL))
|
|
return RET_SYN;
|
|
while (nxtitem(&ni, &nat)) {
|
|
if (nat.nat_stat == STAT_GOD) {
|
|
pr("You may not reject/accept stuff from %s\n"
|
|
"because they are a deity.\n",
|
|
nat.nat_cnam);
|
|
continue;
|
|
}
|
|
if (nat.nat_stat == STAT_UNUSED)
|
|
continue;
|
|
switch (rel) {
|
|
case REJ_ANNO:
|
|
pr("%s annos from %s\n",
|
|
(do_undo == 1 ? "Rejecting" : "Accepting"), nat.nat_cnam);
|
|
break;
|
|
case REJ_LOAN:
|
|
pr("%s loans from %s\n",
|
|
(do_undo == 1 ? "Rejecting" : "Accepting"), nat.nat_cnam);
|
|
break;
|
|
case REJ_TELE:
|
|
pr("%s teles from %s\n",
|
|
(do_undo == 1 ? "Rejecting" : "Accepting"), nat.nat_cnam);
|
|
break;
|
|
}
|
|
setrej(player->cnum, (natid)ni.cur, do_undo, rel);
|
|
}
|
|
return RET_OK;
|
|
}
|