]> git.pond.sub.org Git - empserver/blobdiff - src/lib/commands/mfir.c
Factor feels_like_helping() out of quiet_bigdef(), sd(), dd()
[empserver] / src / lib / commands / mfir.c
index cd518acf9648b5f2107d077f4b6815e62b91a568..1d8925ff176527e3b73ac89dbead62480c1f9002 100644 (file)
@@ -1,6 +1,6 @@
 /*
  *  Empire - A multi-player, client/server Internet based war game.
- *  Copyright (C) 1986-2008, Dave Pare, Jeff Bailey, Thomas Ruschak,
+ *  Copyright (C) 1986-2010, Dave Pare, Jeff Bailey, Thomas Ruschak,
  *                           Ken Stevens, Steve McClure
  *
  *  This program is free software; you can redistribute it and/or modify
  *  ---
  *
  *  multifire.c: Fire at other sectors/ships
- * 
+ *
  *  Known contributors to this file:
  *     Steve McClure, 2000
+ *     Markus Armbruster, 2004-2009
  */
 
 #include <config.h>
 #include "retreat.h"
 
 enum targ_type {
-    targ_land, targ_ship, targ_sub, targ_unit, targ_bogus
+    targ_land, targ_ship, targ_sub, targ_bogus
 };
 
 struct flist {
     struct emp_qelem queue;    /* list of fired things */
     short type;                        /* EF_SECTOR, EF_SHIP or EF_LAND */
-    short uid;
+    int uid;
     coord x, y;
     int defdam;                        /* damage defenders did */
     natid victim;
@@ -64,7 +65,6 @@ int
 multifire(void)
 {
     static int ef_with_guns[] = { EF_SECTOR, EF_SHIP, EF_LAND, EF_BAD };
-    char vbuf[20];
     char *ptr;
     double range;
     int trange, range2;
@@ -72,20 +72,16 @@ multifire(void)
     coord fy;
     coord x;
     coord y;
-    int mil;
     int dam;
     int totaldefdam = 0;
     int vshipno;
-    double prb;
     natid vict;
     struct shpstr fship;
     struct lndstr fland;
     struct sctstr fsect;
     struct shpstr vship;
     struct sctstr vsect;
-    enum targ_type target, attacker, orig_attacker;
-    int rel;
-    struct natstr *natp;
+    enum targ_type target;
     struct nstr_item nbst;
     int type;
     struct empobj *attgp;
@@ -99,39 +95,24 @@ multifire(void)
 
     emp_initque(&fired);
     emp_initque(&defended);
-    if (!(p = getstarg(player->argp[1],
-                      "Firing from ship(s), sect(s), or land unit(s)? ",
-                      buf)))
+    p = getstarg(player->argp[1],
+                "Firing from ship(s), sect(s), or land unit(s)? ", buf);
+    if (!p)
        return RET_SYN;
     type = ef_byname_from(p, ef_with_guns);
-    if (type == EF_SECTOR) {
-       if (opt_NO_FORT_FIRE) {
-           pr("Fort firing is disabled.\n");
-           return RET_FAIL;
-       }
-       orig_attacker = attacker = targ_land;
-    } else if (type == EF_SHIP) {
-       orig_attacker = attacker = targ_ship;
-    } else if (type == EF_LAND) {
-       orig_attacker = attacker = targ_unit;
-    } else {
+    if (opt_NO_FORT_FIRE && type == EF_SECTOR) {
+       pr("Fort firing is disabled.\n");
+       return RET_FAIL;
+    }
+    if (type < 0) {
        pr("Ships, land units or sectors only!\n");
        return RET_SYN;
     }
-    if ((ptr = getstarg(player->argp[2], "Firing from? ", buf)) == 0
-       || *ptr == '\0')
-       return RET_SYN;
-
-    if (!snxtitem(&nbst, type, ptr))
+    if (!snxtitem(&nbst, type, player->argp[2], "Firing from? "))
        return RET_SYN;
 
-    if (player->aborted) {
-       pr("Fire aborted.\n");
-       return RET_OK;
-    }
     while (nxtitem(&nbst, &item)) {
-       attacker = orig_attacker;
-       if (attacker == targ_unit) {
+       if (type == EF_LAND) {
            if (!getland(item.land.lnd_uid, &fland))
                continue;
            if (!getsect(item.land.lnd_x, item.land.lnd_y, &fsect))
@@ -167,7 +148,9 @@ multifire(void)
                pr("%s -- not enough shells\n", prland(&fland));
                continue;
            }
-       } else if (attacker == targ_ship) {
+           fx = fland.lnd_x;
+           fy = fland.lnd_y;
+       } else if (type == EF_SHIP) {
            if (!getship(item.ship.shp_uid, &fship))
                continue;
            if (item.ship.shp_own != player->cnum)
@@ -192,7 +175,9 @@ multifire(void)
                pr("Ship #%d is crippled!\n", item.ship.shp_uid);
                continue;
            }
-       } else if (attacker == targ_land) {
+           fx = fship.shp_x;
+           fy = fship.shp_y;
+       } else {
            if (!getsect(item.sect.sct_x, item.sect.sct_y, &fsect))
                continue;
            if (item.sect.sct_own != player->cnum)
@@ -220,22 +205,17 @@ multifire(void)
            }
            pr("\nSector %s firing\n",
               xyas(item.sect.sct_x, item.sect.sct_y, player->cnum));
+           fx = fsect.sct_x;
+           fy = fsect.sct_y;
        }
-       if ((ptr = getstarg(player->argp[3], "Firing at? ", buf)) == 0
-           || *ptr == '\0')
-           continue;
-       if (player->aborted) {
-           pr("Fire aborted.\n");
+
+       ptr = getstarg(player->argp[3], "Firing at? ", buf);
+       if (!ptr)
+           return RET_FAIL;
+       if (!*ptr)
            continue;
-       }
-       ptr[19] = 0;
-       (void)strcpy(vbuf, ptr);
-       if (issector(vbuf))
-           target = targ_land;
-       else
-           target = targ_ship;
-       if (target == targ_ship) {
-           vshipno = atoi(vbuf);
+       if (!issector(ptr)) {
+           vshipno = atoi(ptr);
            if (vshipno < 0 || !getship(vshipno, &vship) ||
                (!vship.shp_own)) {
                pr("No such ship exists!\n");
@@ -251,7 +231,7 @@ multifire(void)
                continue;
            }
        } else {
-           if (!sarg_xy(vbuf, &x, &y) || !getsect(x, y, &vsect)) {
+           if (!sarg_xy(ptr, &x, &y) || !getsect(x, y, &vsect)) {
                pr("No such sector exists!\n");
                continue;
            }
@@ -266,7 +246,12 @@ multifire(void)
            x = vsect.sct_x;
            y = vsect.sct_y;
        }
-       if (attacker == targ_ship) {
+
+       trange = mapdist(x, y, fx, fy);
+
+       if (type == EF_SHIP) {
+           if (!check_ship_ok(&fship))
+               return RET_FAIL;
            if (fship.shp_own != player->cnum) {
                pr("Not your ship!\n");
                continue;
@@ -277,18 +262,7 @@ multifire(void)
                    continue;
                }
            }
-           fx = fship.shp_x;
-           fy = fship.shp_y;
-/*
-  attacker = (mchr[fship.shp_type].m_flags & M_SUB) ?
-  targ_sub : targ_ship;
-  if (attacker == targ_sub){
-  pr("Subs may not fire normally.. use torpedo.\n");
-  continue;
-  }
-*/
-           attacker = targ_ship;
-           if ((mil = fship.shp_item[I_MILIT]) < 1) {
+           if (fship.shp_item[I_MILIT] < 1) {
                pr("Not enough military for firing crew.\n");
                continue;
            }
@@ -301,13 +275,9 @@ multifire(void)
            range2 = roundrange(range);
            pr("range is %d.00 (%.2f)\n", range2, range);
            if (target == targ_sub
+               && trange <= range2
                && (mchr[(int)fship.shp_type].m_flags & M_DCH)) {
                dam = shp_dchrg(&fship);
-               putship(fship.shp_uid, &fship);
-               if (dam < 0) {
-                   pr("Not enough shells for depth charge!\n");
-                   continue;
-               }
            } else {
                if (target == targ_sub)
                    /* Don't tell it's a sub */
@@ -317,17 +287,19 @@ multifire(void)
                    continue;
                }
                dam = shp_fire(&fship);
-               putship(fship.shp_uid, &fship);
-               if (dam <= 0) {
-                   pr("Klick!     ...\n");
-                   continue;
-               }
+           }
+           putship(fship.shp_uid, &fship);
+           if (dam <= 0) {
+               pr("Klick!     ...\n");
+               continue;
            }
            if (opt_NOMOBCOST == 0) {
                fship.shp_mobil = MAX(fship.shp_mobil - 15, -100);
                putship(fship.shp_uid, &fship);
            }
-       } else if (attacker == targ_unit) {
+       } else if (type == EF_LAND) {
+           if (!check_land_ok(&fland))
+               return RET_FAIL;
            if (fland.lnd_own != player->cnum) {
                pr("Not your unit!\n");
                continue;
@@ -341,9 +313,6 @@ multifire(void)
                }
            }
 
-           fx = fland.lnd_x;
-           fy = fland.lnd_y;
-
            if (lchr[fland.lnd_type].l_dam == 0) {
                pr("Unit %d cannot fire!\n", fland.lnd_uid);
                continue;
@@ -372,8 +341,8 @@ multifire(void)
                    dam = ldround(dam / 2.0, 1);
            }
        } else {
-           fx = fsect.sct_x;
-           fy = fsect.sct_y;
+           if (!check_sect_ok(&fsect))
+               return RET_FAIL;
            if (fsect.sct_own != player->cnum ||
                fsect.sct_type != SCT_FORTR) {
                pr("No fortress at %s\n",
@@ -387,7 +356,6 @@ multifire(void)
                    continue;
                }
            }
-           attacker = targ_land;
            if (fsect.sct_item[I_GUN] == 0) {
                pr("Insufficient arms.\n");
                continue;
@@ -410,47 +378,25 @@ multifire(void)
                range2 = -1;
            }
        }
-       trange = mapdist(x, y, fx, fy);
        if (trange > range2) {
            pr("Target out of range.\n");
-/*
-                       switch (target) {
-                       case targ_land:
-                       case targ_bogus:
-                               pr("Target out of range.  Thud.\n");
-                               break ;
-                       default:
-                               pr("Target ship out of range.  Splash.\n");
-                               break ;
-                       }       
- */
-           switch (attacker) {
-           case targ_land:
+           switch (type) {
+           case EF_SECTOR:
                putsect(&fsect);
                break;
-           case targ_unit:
+           case EF_LAND:
                fland.lnd_mission = 0;
                putland(fland.lnd_uid, &fland);
                break;
-           default:
+           case EF_SHIP:
                fship.shp_mission = 0;
                putship(fship.shp_uid, &fship);
+               break;
+           default:
+               CANT_REACH();
            }
            continue;
        }
-/*
-               if (target == targ_bogus) {
-                       if (vsect.sct_type == SCT_SANCT) {
-                               pr("%s is a %s!!\n", vbuf,
-                                  dchr[SCT_SANCT].d_name);
-                               continue;
-                       } else if (vsect.sct_type == SCT_WATER) {
-                               pr("You must specify a ship in sector %s!\n",
-                                  vbuf);
-                               continue;
-                       }
-               }
-*/
        switch (target) {
        case targ_ship:
            if (!trechk(player->cnum, vict, SEAFIR))
@@ -460,7 +406,6 @@ multifire(void)
            if (!trechk(player->cnum, vict, SUBFIR))
                continue;
            break;
-       case targ_unit:
        case targ_land:
            if (!trechk(player->cnum, vict, LANFIR))
                continue;
@@ -469,37 +414,15 @@ multifire(void)
            break;
        }
 
-       if (opt_SLOW_WAR) {
-           if (target == targ_land) {
-               natp = getnatp(player->cnum);
-               rel = getrel(natp, vict);
-               if ((rel != AT_WAR) && (player->cnum != vict) &&
-                   (vict) && (vsect.sct_oldown != player->cnum)) {
-                   pr("You're not at war with them!\n");
-                   continue;
-               }
-           }
-       }
        nfiring++;
        switch (target) {
        case targ_sub:
            pr_beep();
            pr("Kawhomp!!!\n");
-           if (vship.shp_rflags & RET_DCHRGED)
-               retreat_ship(&vship, 'd');
            break;
        default:
            pr_beep();
            pr("Kaboom!!!\n");
-           prb = range2 ? (double)trange / range2 : 1.0;
-           prb *= prb;
-           if (chance(prb)) {
-               pr("Wind deflects shells.\n");
-/*                     dam = (int)(dam / 2.0);*/
-               dam *= (90 - (random() % 11)) / 100.0;
-               if (dam < 0)
-                   dam = 0;
-           }
            break;
        }
        switch (target) {
@@ -512,19 +435,11 @@ multifire(void)
                   player->cnum, xyas(x, y, vict), dam);
            pr("Shells hit sector %s for %d damage.\n",
               xyas(x, y, player->cnum), dam);
-           /* Ok, it wasn't a bogus target, so do damage. */
-           if (target != targ_bogus)
-               sectdamage(&vsect, dam, 0);
            break;
        case targ_ship:
            nreport(player->cnum, N_SHP_SHELL, vict, 1);
            /* fall through */
        default:
-           if ((target != targ_sub) ||
-               ((vship.shp_rflags & RET_DCHRGED) == 0))
-               check_retreat_and_do_shipdamage(&vship, dam);
-           else
-               shipdamage(&vship, dam);
            if (vict) {
                wu(0, vict,
                   "Country #%d shelled %s in %s for %d damage.\n",
@@ -534,10 +449,6 @@ multifire(void)
            pr("Shells hit %s in %s for %d damage.\n",
               prsub(&vship),
               xyas(vship.shp_x, vship.shp_y, player->cnum), dam);
-
-           if (vship.shp_effic < SHIP_MINEFF)
-               pr("%s sunk!\n", prsub(&vship));
-
            break;
        }
        /*  Ok, now, check if we had a bogus target.  If so,
@@ -545,28 +456,38 @@ multifire(void)
        if (target == targ_bogus)
            continue;
        attgp = &item.gen;
-       if (attacker == targ_unit) {
-           attacker = targ_land;
+       if (type == EF_LAND) {
            getsect(fland.lnd_x, fland.lnd_y, &fsect);
            attgp = (struct empobj *)&fsect;
        }
        totaldefdam = defend(&fired, &defended, attgp, vict, &ndefending);
        switch (target) {
        case targ_land:
+           getsect(x, y, &vsect);
+           sectdamage(&vsect, dam);
            putsect(&vsect);
            break;
        default:
+           getship(vshipno, &vship);
+           check_retreat_and_do_shipdamage(&vship, dam);
+           if (vship.shp_effic < SHIP_MINEFF)
+               pr("%s sunk!\n", prsub(&vship));
+           else if (target == targ_sub
+               && (vship.shp_rflags & RET_DCHRGED)
+               && !(vship.shp_rflags & RET_INJURED))
+               retreat_ship(&vship, 'd');
            putship(vship.shp_uid, &vship);
            break;
        }
-       if ((totaldefdam == 0) && (target == targ_ship))
-           if (vship.shp_rflags & RET_HELPLESS)
-               retreat_ship(&vship, 'h');
-       switch (attacker) {
-       case targ_land:
+       if (totaldefdam == 0 && target == targ_ship
+           && (vship.shp_rflags & RET_HELPLESS)
+           && !(vship.shp_rflags & RET_INJURED))
+           retreat_ship(&vship, 'h');
+       switch (attgp->ef_type) {
+       case EF_SECTOR:
            putsect(&fsect);
            break;
-       default:
+       case EF_SHIP:
            if ((target == targ_ship) || (target == targ_sub)) {
                if (fship.shp_effic > SHIP_MINEFF) {
                    shp_missdef(&fship, vict);
@@ -574,6 +495,8 @@ multifire(void)
            };
            putship(fship.shp_uid, &fship);
            break;
+       default:
+           CANT_REACH();
        }
     }
 
@@ -646,7 +569,7 @@ do_defdam(struct emp_qelem *list, double odds)
            vict = fp->victim;
            pr("Return fire hit sector %s for %d damage.\n",
               xyas(fp->x, fp->y, player->cnum), dam);
-           sectdamage(&sect, dam, 0);
+           sectdamage(&sect, dam);
            putsect(&sect);
            if (vict)
                wu(0, vict, "Return fire hit sector %s for %d damage.\n",
@@ -665,7 +588,7 @@ quiet_bigdef(int type, struct emp_qelem *list, natid own, natid aown,
     struct shpstr ship;
     struct lndstr land;
     struct nstr_item ni;
-    int dam, dam2, rel, rel2;
+    int dam, dam2;
     struct sctstr firing;
     struct nstr_sect ns;
     struct flist *fp;
@@ -675,19 +598,12 @@ quiet_bigdef(int type, struct emp_qelem *list, natid own, natid aown,
     dam = 0;
     snxtitem_dist(&ni, EF_SHIP, ax, ay, 8);
     while (nxtitem(&ni, &ship)) {
-       if (ship.shp_own == 0)
+       if (!feels_like_helping(ship.shp_own, own, aown))
            continue;
 
        if ((mchr[ship.shp_type].m_flags & M_SUB) && type != EF_SHIP)
            continue;
 
-       rel = getrel(getnatp(ship.shp_own), own);
-       rel2 = getrel(getnatp(ship.shp_own), aown);
-       if ((ship.shp_own != own) && ((rel != ALLIED) || (rel2 != AT_WAR)))
-           continue;
-       /* Don't shoot yourself */
-       if (ship.shp_own == aown)
-           continue;
        if (mchr[(int)ship.shp_type].m_flags & M_SUB) {
            erange = torprange(&ship);
            if (roundrange(erange) < ni.curdist)
@@ -727,16 +643,7 @@ quiet_bigdef(int type, struct emp_qelem *list, natid own, natid aown,
     }
     snxtitem_dist(&ni, EF_LAND, ax, ay, 8);
     while (nxtitem(&ni, &land)) {
-       if (land.lnd_own == 0)
-           continue;
-       /* Don't shoot yourself */
-       if (land.lnd_own == aown)
-           continue;
-
-       rel = getrel(getnatp(land.lnd_own), own);
-       rel2 = getrel(getnatp(land.lnd_own), aown);
-
-       if ((land.lnd_own != own) && ((rel != ALLIED) || (rel2 != AT_WAR)))
+       if (!feels_like_helping(land.lnd_own, own, aown))
            continue;
 
        erange = lnd_fire_range(&land);
@@ -757,6 +664,10 @@ quiet_bigdef(int type, struct emp_qelem *list, natid own, natid aown,
        if (!fp)
            add_to_flist(list, (struct empobj *)&land, dam2, 0);
        nreport(land.lnd_own, N_FIRE_BACK, player->cnum, 1);
+       if (type == EF_SHIP) {
+           if (chance(lnd_acc(&land) / 100.0))
+               dam2 = ldround(dam2 / 2.0, 1);
+       }
        dam += dam2;
     }
 
@@ -770,17 +681,9 @@ quiet_bigdef(int type, struct emp_qelem *list, natid own, natid aown,
     if (!opt_NO_FORT_FIRE) {
        snxtsct_dist(&ns, ax, ay, 8);
        while (nxtsct(&ns, &firing)) {
-           if (firing.sct_own == 0)
+           if (!feels_like_helping(firing.sct_own, own, aown))
                continue;
-           rel = getrel(getnatp(firing.sct_own), own);
-           rel2 = getrel(getnatp(firing.sct_own), aown);
 
-           if ((firing.sct_own != own) &&
-               ((rel != ALLIED) || (rel2 != AT_WAR)))
-               continue;
-           /* Don't shoot yourself */
-           if (firing.sct_own == aown)
-               continue;
            erange = fortrange(&firing);
            if (roundrange(erange) < ns.curdist)
                continue;