(lrange, shoo, execute): Buffer passed to getstarg() was too small.

Player could overrun it!

diff --git a/src/lib/commands/rang.c b/src/lib/commands/rang.c
index 47d6336919b2a0a9a292b6c21aeff82bdd96e914..88884edb1d57b7f0044e642f6486a28932105a76 100644 (file)
--- a/src/lib/commands/rang.c
+++ b/src/lib/commands/rang.c
@@ -76,9 +76,9 @@ lrange(void)
     struct lndstr land;
     struct lchrstr *lcp;
     int i;
-    s_char *p;
-    s_char prompt[128];
-    s_char buf[128];
+    char *p;
+    char prompt[128];
+    char buf[1024];
 
     if (!snxtitem(&np, EF_LAND, player->argp[1]))
        return RET_SYN;

diff --git a/src/lib/commands/shoo.c b/src/lib/commands/shoo.c
index 03411d8c21770c5f0a51f82b573d1db970c5c154..6d75c25ce315f3ab0fb2e0929109ff004148a424 100644 (file)
--- a/src/lib/commands/shoo.c
+++ b/src/lib/commands/shoo.c
@@ -57,10 +57,10 @@ shoo(void)
     struct ichrstr *ip;
     struct lndstr land;
     int targets;
-    s_char *p;
+    char *p;
     int mil, nsec;
-    s_char prompt[128];
-    s_char buf[128];
+    char prompt[128];
+    char buf[1024];
 
     ip = whatitem(player->argp[1], "Shoot what <civ or uw> ");
     if (ip == 0 || (ip->i_vtype != I_CIVIL && ip->i_vtype != I_UW))

diff --git a/src/lib/player/player.c b/src/lib/player/player.c
index e465235af8c896f52f879b4fa2489225b95aa073..88d600b6ac00bf05011038f695783e93f1211e49 100644 (file)
--- a/src/lib/player/player.c
+++ b/src/lib/player/player.c
@@ -303,7 +303,7 @@ status(void)
 int
 execute(void)
 {
-    char buf[512];
+    char buf[1024];
     int failed;
     char *p;
     char *redir;