Change GODNEWS reports not to affect headlines and relations

Option GODNEWS controls news reports give's N_GIFT, N_TAKE, and edit's
and setsector's N_AIDS, N_HURTS.

They affect news headlines because of their non-zero r_good_will.
N_TAKE and N_HURTS can downgrade relations because of their negative
r_good_will.  All tolerable, except N_TAKE has actor and victim
reverted: the deity running the give command is the victim, and the
sector owner is the actor.  Because of that, give with a negative
amount downgrades the deity's relations towards the sector owner.
Inappropriate.

Has always been that way.  Chainsaw disabled these news at
compile-time; to enable you had to define GODNEWS (not documented
anywhere).  Empire 4.2.0 made GODNEWS a proper option, enabled by
default.

Fix by setting their r_good_will to zero.

diff --git a/src/lib/global/news.c b/src/lib/global/news.c
index 3f40c60a7f6f8d3e6a9fb1f551a0cb7a8c87e8fb..1ba478461b87942912d825e9f7354443a2db6bcd 100644 (file)
--- a/src/lib/global/news.c
+++ b/src/lib/global/news.c
@@ -125,13 +125,13 @@ struct rptstr rpt[] = {
                               "continues its conquest of space with a successful launch" } },
     { N_SAT_KILL, -8, N_MISS,  { "strikes a %s big bird",
                                 "rockets damage a %s satellite" } },
-    { N_GIFT,  4, N_ECON,  { "makes a contribution to %s",
+    { N_GIFT,  0, N_ECON,  { "makes a contribution to %s",
                             "helps out %s" } },
-    { N_AIDS,  2, N_HOME,  { "aids %s with divine intervention",
+    { N_AIDS,  0, N_HOME,  { "aids %s with divine intervention",
                             "smiles upon %s" } },
-    { N_HURTS, -3, N_HOME,  { "hurts %s with divine intervention",
+    { N_HURTS,  0, N_HOME,  { "hurts %s with divine intervention",
                              "frowns upon %s" } },
-    { N_TAKE, -4, N_ECON,  { "sacrifices to %s",
+    { N_TAKE,  0, N_ECON,  { "sacrifices to %s",
                             "makes divine payment to %s" } },
     { N_NUKE_STOP, -10,N_MISS,  { "abms intercept a %s missile",
                                  "strategic defense systems destroy a %s missile" } },