arm: Rework "cannot carry nukes" test for robustness
authorMarkus Armbruster <armbru@pond.sub.org>
Fri, 11 May 2018 16:57:47 +0000 (18:57 +0200)
committerMarkus Armbruster <armbru@pond.sub.org>
Sun, 17 Jan 2021 20:24:29 +0000 (21:24 +0100)
We reject satellites, ABMs, anti-ship missiles, and SAMs.  That's
enumerating badness.  More robust replacement: accept only bomber,
tactical, cargo, except for anti-ship missiles.

Throw in PLN_LAUNCHED sanity checking while there.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
src/lib/commands/arm.c

index d412c642a4882c3eafc36d56f9793781b2e7bad5..74ea9485eb69487f22b8a614e740f349efbed02c 100644 (file)
@@ -30,7 +30,7 @@
  *     Dave Pare, 1986
  *     Ken Stevens, 1995
  *     Steve McClure, 2000
- *     Markus Armbruster, 2006-2011
+ *     Markus Armbruster, 2006-2021
  */
 
 #include <config.h>
@@ -61,11 +61,13 @@ arm(void)
            && relations_with(pl.pln_own, player->cnum) != ALLIED)
            continue;
        plc = &plchr[(int)pl.pln_type];
-       if ((plc->pl_flags & (P_O | P_N | P_MAR))
-           || (plc->pl_flags & (P_M | P_F)) == (P_M | P_F)) {
+       if (!(plc->pl_flags & (P_B | P_T | P_C))
+           || (plc->pl_flags & P_MAR)) {
            pr("A %s cannot carry nuclear devices!\n", plc->pl_name);
            return RET_FAIL;
        }
+       if (CANT_HAPPEN(pl.pln_flags & PLN_LAUNCHED))
+           continue;
        if (opt_MARKET) {
            if (ontradingblock(EF_PLANE, &pl)) {
                pr("You cannot arm %s while it is on the trading block!\n",
@@ -145,6 +147,8 @@ disarm(void)
            continue;
        if (!getnuke(nuk_on_plane(&pl), &nuke))
            continue;
+       if (CANT_HAPPEN(pl.pln_flags & PLN_LAUNCHED))
+           continue;
        if (opt_MARKET) {
            if (ontradingblock(EF_PLANE, &pl)) {
                pr("You cannot disarm %s while it is on the trading block!\n",