empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

accept: Drop outdated FIXME SO_KEEPALIVE

Browse source 
SO_KEEPALIVE isn't useless with long idle timeouts.  Before v4.3.30's
idle timeout changes, such long timeouts had serious drawbacks (easy
denial of service), but they're just fine since then.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
This commit is contained in:
Markus Armbruster 2013-08-11 13:53:52 +02:00
parent 682a035b7c
commit 122cb5fc3b
1 changed files with 0 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/lib/player/accept.c
View file

@ -201,7 +201,6 @@ player_accept(void *unused)
logerror("new socket accept"); logerror("new socket accept");
continue; continue;
} }
/* FIXME SO_KEEPALIVE is useless, player_kill_idle() strikes long before */
(void)setsockopt(ns, SOL_SOCKET, SO_KEEPALIVE, &set, sizeof(set)); (void)setsockopt(ns, SOL_SOCKET, SO_KEEPALIVE, &set, sizeof(set));
np = player_new(ns); np = player_new(ns);
if (!np) { if (!np) {