empire/empserver
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fire: Fix artillery splashing the bridge span under itself

Browse source 
multifire() writes back the firing sector after applying damage.  When
an artillery unit on a bridge span commits suicide by shelling down
the supporting bridge heads, this writeback puts the bridge span right
back (less the land units and planes on it), triggering a seqno oops.
On the next update of the bridge head, the bridge span falls again.
Broken in commit fe5b266, v4.3.14.

The problematic write back is superfluous.  Remove it along with a few
equally superfluous ones.

Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
This commit is contained in:
Markus Armbruster 2015-02-07 15:49:03 +01:00
parent 48d8533443
commit c88344dad4
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/lib/commands/mfir.c
View file

@ -352,7 +352,6 @@ multifire(void)
pr("Target out of range.\n"); pr("Target out of range.\n");
switch (type) { switch (type) {
case EF_SECTOR: case EF_SECTOR:
putsect(&fsect);
break; break;
case EF_LAND: case EF_LAND:
fland.lnd_mission = 0; fland.lnd_mission = 0;
@ -437,7 +436,6 @@ multifire(void)
} }
switch (attgp->ef_type) { switch (attgp->ef_type) {
case EF_SECTOR: case EF_SECTOR:
putsect(&fsect);
break; break;
case EF_SHIP: case EF_SHIP:
if ((target == targ_ship) || (target == targ_sub)) { if ((target == targ_ship) || (target == targ_sub)) {
@ -445,7 +443,6 @@ multifire(void)
shp_missdef(&fship, vict); shp_missdef(&fship, vict);
} }
} }
putship(fship.shp_uid, &fship);
break; break;
default: default:
CANT_REACH(); CANT_REACH();