match info as well as related commands `sstat' and `pstat'. Rename
lstats() to lsta() to uphold the convention that functions
implementing commands are named like the command or its four character
prefix. Closes#804587.
that commands must be unique within the first four letters. best()
implements both. It calls BestDistPath() for the former, and
BestLandPath() for the latter. However, BestDistPath() is just a
wrapper around BestLandPath(); it does exactly the same. Drop
`bestdistpath'.
effect. Replace calls by struct assignment where possible. Replace
clear buffer, copy string to buffer by strncpy(). Use assignment to
clear when that's clearer. Replace overlapping copy through bounce
buffer by memmove(). Replace rest by standard memset() and memcpy().
Also use sizeof() instead of literal array sizes for robustness, and
instead of symbolic array sizes for clarity.
windows. For obvious reasons, such warnings ought to be fixed.
Making compilation abort is the sledgehammer method to force that.
It's a stupid method for us, as we develop on various platforms, and
don't test every single commit under Windows. It gratuitously breaks
programs that work fine. Leave them as warnings, and fix them on
sight.
number. Check is redundant, because invalid values can come only from
natarg(), and those are checked above. Check is broken because
natarg() returns negative value on error, not 255.
