]>
git.pond.sub.org Git - empserver/log
Markus Armbruster [Mon, 27 Mar 2006 18:42:18 +0000 (18:42 +0000)]
(unit_map): Simplify.
Markus Armbruster [Mon, 27 Mar 2006 18:20:25 +0000 (18:20 +0000)]
(explore_map, nav_map, move_map, fly_map): Don't use snxtsct(), it
obeys conditionals. Use snxtsct_dist(). Closes #785447. Only march
and test were actually broken, the other uses zapped conditionals.
(move_map, fly_map, nav_map, navi): Don't zap conditionals.
Markus Armbruster [Sun, 26 Mar 2006 19:21:13 +0000 (19:21 +0000)]
(bsanct): Use snxtitem_all() instead of snxtitem(). The latter uses
player->condarg, which lets players keep sanctuaries. Broken in the
early 90s.
Markus Armbruster [Sun, 26 Mar 2006 19:09:06 +0000 (19:09 +0000)]
(retreat_ship1, retreat_land1): Use snxtitem_group() instead of
snxtitem() for RET_GROUP. The latter uses player->condarg, which lets
crafty attackers suppress retreat.
Markus Armbruster [Sun, 26 Mar 2006 19:02:28 +0000 (19:02 +0000)]
(conditions): Give sentinel a legible desc[], just in case.
(findcondition): Oops on hitting the sentinel.
(retreat_ship1, retreat_land1): Don't bother to map code to lower
case, it doesn't occur.
Markus Armbruster [Sun, 26 Mar 2006 17:36:27 +0000 (17:36 +0000)]
The previous revision is wrong, back it out.
Markus Armbruster [Sun, 26 Mar 2006 17:34:58 +0000 (17:34 +0000)]
The revision before the previous one is partially wrong, back out the
bad parts.
Markus Armbruster [Sun, 26 Mar 2006 17:33:46 +0000 (17:33 +0000)]
The revision before the previous one is wrong, back it out.
Markus Armbruster [Sun, 26 Mar 2006 15:07:32 +0000 (15:07 +0000)]
(file_sct_init, fl_sct_init): Fix parameter type from s_char * to
struct sctstr *. Callers changed not to cast.
Markus Armbruster [Sun, 26 Mar 2006 14:42:27 +0000 (14:42 +0000)]
(retr, lretr, doship, dounit): Zero-terminate retreat paths. The last
character in the array must be zero already. Closes #
1225708 .
Markus Armbruster [Sun, 26 Mar 2006 14:03:50 +0000 (14:03 +0000)]
(sd): Supply missing parenthesis for a cast from double to int. The
cast is only there to express intent, it doesn't change the meaning of
the code.
Markus Armbruster [Sun, 26 Mar 2006 13:59:47 +0000 (13:59 +0000)]
(shut): Fix misuse of logerror(): passed formatted string instead of
format string and arguments. Correctness depends on formatted string
not containing '%', which is the case.
Markus Armbruster [Sun, 26 Mar 2006 13:57:34 +0000 (13:57 +0000)]
(show_sail): Fix misuse of pr(): passed formatted string instead of
format string and arguments. Correctness depends on paths not
containing '%', which is correct, but not as robust as it could be.
Markus Armbruster [Sun, 26 Mar 2006 13:55:29 +0000 (13:55 +0000)]
(unit_interdict, knockdown): Simplify. No functional change.
Markus Armbruster [Sun, 26 Mar 2006 13:52:23 +0000 (13:52 +0000)]
Code formatting. No functional changes.
Markus Armbruster [Sun, 26 Mar 2006 13:41:46 +0000 (13:41 +0000)]
(show_nuke_capab, show_ship_capab, show_plane_capab, show_land_capab)
(prxy, border, ac_encounter, look, budg): Fix misuse of pr() and PR():
passed formatted string instead of format string and arguments.
Correctness depends on argument values and tables not containing '%',
which is correct, but fragile.
Markus Armbruster [Sun, 26 Mar 2006 13:34:35 +0000 (13:34 +0000)]
(comm_bomb, ship_bomb, land_bomb, pinflak_planedamage): Fix dangerous
misuse of pr(), PR() and mpr(): passed formatted string instead of
format string and arguments. Crash bug if formatted string contains
'%'. Players can put that in ship names...
Markus Armbruster [Sun, 26 Mar 2006 12:54:52 +0000 (12:54 +0000)]
(prunits, prplanes): Simplify, compute relation string instead of
format.
(prplanes): Fix dangerous misuse of pr(): passed formatted string
instead of format string and arguments. Crash bug if formatted string
contains '%'. Players can put that in country names...
Markus Armbruster [Sun, 26 Mar 2006 12:37:22 +0000 (12:37 +0000)]
(prod): Simplify printing of materials used. Don't assume amount fits
into eight characters and item mnemo can't be '%'.
Markus Armbruster [Sun, 26 Mar 2006 12:08:35 +0000 (12:08 +0000)]
(head_describe): Print the headline instead of returning the format
string. This simplifies format string checking.
Markus Armbruster [Sun, 26 Mar 2006 10:21:57 +0000 (10:21 +0000)]
(prthresh): Remove format string parameter. Callers don't really need
that flexibility, and it makes format checking harder.
Markus Armbruster [Sun, 26 Mar 2006 10:16:08 +0000 (10:16 +0000)]
Remove useless multiplications with sizeof(char) and sizeof(s_char).
Replace by literal 1 in other contexts.
Markus Armbruster [Sun, 26 Mar 2006 08:18:34 +0000 (08:18 +0000)]
(gift): Fix parameter types: natid instead of int, void * for generic
pointer, char * for string.
Markus Armbruster [Sun, 26 Mar 2006 08:15:27 +0000 (08:15 +0000)]
(gift, load_comm_ship, load_comm_land): Fix dangerous misuse of wu():
passed formatted string instead of format string and arguments. Crash
bug if formatted string contains '%'. Players can put that in ship
names...
Markus Armbruster [Sun, 26 Mar 2006 07:46:49 +0000 (07:46 +0000)]
Remove silly superflous parenthesis.
Markus Armbruster [Sat, 25 Mar 2006 20:11:55 +0000 (20:11 +0000)]
(getele): Zero-terminate empty telegrams. Returned telegram was
broken in rev. 1.9. ~p never worked.
Markus Armbruster [Sat, 25 Mar 2006 19:59:21 +0000 (19:59 +0000)]
Fix land unit speed. Reported by Pat Loney. Fix spelling.
Markus Armbruster [Sat, 25 Mar 2006 19:16:35 +0000 (19:16 +0000)]
(buil): Simplify the loop for building multiple units. Unit type
argument "" no longer makes it prompt for the unit type on every
iteration.
Markus Armbruster [Sat, 25 Mar 2006 18:56:34 +0000 (18:56 +0000)]
(buil): Return RET_FAIL on insufficient tech for bridge instead of
literal 2 (which is RET_SYN). Return RET_SYN on incorrect first
argument.
Markus Armbruster [Sat, 25 Mar 2006 16:36:45 +0000 (16:36 +0000)]
(build_ship, build_land, build_plane): Compute cost in floating-point.
It's better to round just once, when subtracting player->dolcost from
nat_money.
Markus Armbruster [Sat, 25 Mar 2006 16:21:48 +0000 (16:21 +0000)]
(build_can_afford): New.
(build_ship, build_land, build_bridge, build_nuke, build_plane)
(build_tower): Use it. This changes some messages. Fixes ancient
bridge building race condition: while prompting for direction, another
build could clobber cash.
(cash): Remove.
Markus Armbruster [Sat, 25 Mar 2006 15:26:29 +0000 (15:26 +0000)]
(trade_check_item_ok): New.
(trade_check_ok): Use it and simplify.
(set): Use new trade_check_item_ok(). The code replaced by it didn't
work (abusable bug).
Markus Armbruster [Sat, 25 Mar 2006 15:11:17 +0000 (15:11 +0000)]
(ontradingblock, trdswitchown): Second parameter is a generic pointer,
change it from int * to void *. Callers changed not to cast to int *.
Markus Armbruster [Sat, 25 Mar 2006 15:03:32 +0000 (15:03 +0000)]
(genstr): Redundant. Replace by struct genitem.
Markus Armbruster [Sat, 25 Mar 2006 10:15:13 +0000 (10:15 +0000)]
Define feature test macro required for PTHREAD_STACK_MIN on some
systems, e.g. Solaris.
Markus Armbruster [Sat, 25 Mar 2006 09:08:58 +0000 (09:08 +0000)]
Fix the previous revision.
Markus Armbruster [Sat, 25 Mar 2006 07:49:37 +0000 (07:49 +0000)]
(empth_create): LWP yields, and it's the reference implementation.
Document and fix the others.
Markus Armbruster [Sat, 25 Mar 2006 07:05:34 +0000 (07:05 +0000)]
(u_char, u_short, u_int): BSDisms. Figuring out whether sys/types.h
defines them would be possible, but isn't worth the trouble. Replace
by unabbreviated types.
Markus Armbruster [Thu, 23 Mar 2006 20:48:49 +0000 (20:48 +0000)]
Use NULL instead of (FOO *)0, it's easier to read.
Markus Armbruster [Thu, 23 Mar 2006 20:32:29 +0000 (20:32 +0000)]
(dirchar, neighsects, login_coms, lookup_list, g_distptrs, level_easy)
(level_log, levelnames): Internal linkage.
Markus Armbruster [Thu, 23 Mar 2006 20:13:38 +0000 (20:13 +0000)]
(map): Simplify loop control.
Markus Armbruster [Thu, 23 Mar 2006 19:50:25 +0000 (19:50 +0000)]
(marc, navi): Permit any whitespace between route and optional
argument for radar, lookout, sonar, not just spaces.
Markus Armbruster [Thu, 23 Mar 2006 07:58:03 +0000 (07:58 +0000)]
(do_conv, enli, explore, move, shoo, s_commod): sct_mobil was changed
from u_char to short in 3.0.0, but many assignments still cast to
u_char. Remove casts.
Markus Armbruster [Thu, 23 Mar 2006 07:46:26 +0000 (07:46 +0000)]
(do_mob_ship, do_mob_land): Remove superflous casts.
(do_mob_land): Remove superflous check for excess mobility.
Markus Armbruster [Thu, 23 Mar 2006 06:54:56 +0000 (06:54 +0000)]
Previous revision broke canal navigation, fix.
Markus Armbruster [Thu, 23 Mar 2006 06:17:30 +0000 (06:17 +0000)]
Bump version to 4.3.1.
Markus Armbruster [Sun, 19 Mar 2006 10:05:20 +0000 (10:05 +0000)]
Fix editing accident in revision before the previous. More 4.3.0
polishing.
Markus Armbruster [Sun, 19 Mar 2006 08:24:52 +0000 (08:24 +0000)]
Update 4.3.0 date.
Markus Armbruster [Sat, 18 Mar 2006 18:14:56 +0000 (18:14 +0000)]
Terminology fix.
Markus Armbruster [Sat, 18 Mar 2006 18:13:14 +0000 (18:13 +0000)]
Hints on GNU make.
Markus Armbruster [Sat, 18 Mar 2006 17:46:32 +0000 (17:46 +0000)]
(CFLAGS, CPPFLAGS): POSIX make has only CFLAGS. Fold CPPFLAGS into
CFLAGS. Use CFLAGS when linking, to match POSIX make implicit rule.
Markus Armbruster [Sat, 18 Mar 2006 16:46:58 +0000 (16:46 +0000)]
Search for terminal stuff in -lcurses as well.
Markus Armbruster [Sat, 11 Mar 2006 08:40:27 +0000 (08:40 +0000)]
Correct reference to doc/xdump.
Markus Armbruster [Sat, 11 Mar 2006 08:36:50 +0000 (08:36 +0000)]
Refer to xdump.
Markus Armbruster [Thu, 9 Mar 2006 22:04:17 +0000 (22:04 +0000)]
(may_play): More helpful diagnosis and log.
Markus Armbruster [Thu, 9 Mar 2006 21:51:27 +0000 (21:51 +0000)]
(privip): Lacked the IPv4 mapped IPv6 address for localhost.
Markus Armbruster [Thu, 9 Mar 2006 21:21:58 +0000 (21:21 +0000)]
Use touch to touch stamp files, > doesn't update mtime of existing
file on some systems. Weird.
Markus Armbruster [Thu, 9 Mar 2006 20:58:36 +0000 (20:58 +0000)]
(client): Don't make $(termlib) a prerequisite, pass it in $(LDLIBS).
The old version didn't work on some systems.
Markus Armbruster [Wed, 8 Mar 2006 20:19:45 +0000 (20:19 +0000)]
Final polish for 4.3.0.
Markus Armbruster [Wed, 8 Mar 2006 20:16:18 +0000 (20:16 +0000)]
Doc fix.
Markus Armbruster [Wed, 8 Mar 2006 20:10:43 +0000 (20:10 +0000)]
*** empty log message ***
Ron Koenderink [Wed, 8 Mar 2006 18:45:56 +0000 (18:45 +0000)]
(termio) [_WIN32]: Change remaining "n"s to "records" for the
WIN32 ReadConsole(). Fixes broken exec command.
Broken in Rev 1.17.
Markus Armbruster [Wed, 8 Mar 2006 18:07:30 +0000 (18:07 +0000)]
*** empty log message ***
Markus Armbruster [Tue, 7 Mar 2006 19:06:36 +0000 (19:06 +0000)]
Update.
Markus Armbruster [Mon, 6 Mar 2006 19:39:17 +0000 (19:39 +0000)]
Update for 4.3.0.
Markus Armbruster [Mon, 6 Mar 2006 19:28:39 +0000 (19:28 +0000)]
Update.
Markus Armbruster [Mon, 6 Mar 2006 19:27:32 +0000 (19:27 +0000)]
Cosmetics.
Markus Armbruster [Mon, 6 Mar 2006 18:33:52 +0000 (18:33 +0000)]
xdump's no longer experimental, update accordingly.
Markus Armbruster [Mon, 6 Mar 2006 18:33:00 +0000 (18:33 +0000)]
Caution deities on customization.
Markus Armbruster [Mon, 6 Mar 2006 18:27:37 +0000 (18:27 +0000)]
New doc/xdump.
Markus Armbruster [Mon, 6 Mar 2006 18:24:39 +0000 (18:24 +0000)]
Doc fix.
Markus Armbruster [Mon, 6 Mar 2006 18:23:41 +0000 (18:23 +0000)]
(ef_open): Zero cache size (empty EFF_MEM file) can lead to null cache
on some systems, which confuses assertions. Force non-zero size.
Markus Armbruster [Mon, 6 Mar 2006 18:21:36 +0000 (18:21 +0000)]
AIX needs -lcurses for setupterm().
Markus Armbruster [Sat, 4 Mar 2006 21:18:15 +0000 (21:18 +0000)]
MSYS ships an obsolete version of GNU make which doesn't grok
order-only prerequisites. They were used to make directories
info.html, info.nr, lib. Make them ahead of time, in configure. Also
fixes distclean not removing them.
Markus Armbruster [Sat, 4 Mar 2006 06:55:12 +0000 (06:55 +0000)]
Check for -lws2_32 properly. The old code relied on $host_os, which
wasn't defined.
Markus Armbruster [Wed, 1 Mar 2006 07:21:14 +0000 (07:21 +0000)]
Doc fix.
Markus Armbruster [Tue, 28 Feb 2006 21:19:21 +0000 (21:19 +0000)]
Doc update.
Markus Armbruster [Tue, 28 Feb 2006 20:09:54 +0000 (20:09 +0000)]
(player_coms): Update xdump's c_form to current syntax.
Markus Armbruster [Tue, 28 Feb 2006 20:04:09 +0000 (20:04 +0000)]
Remove note on self-documenting econfig, as it's of historical
interest only.
Explain how to use custom_tables.
Markus Armbruster [Mon, 27 Feb 2006 20:58:26 +0000 (20:58 +0000)]
Update to current command syntax, cover meta. Refer to doc/xdump (to
be written). Less detail on output. Document current shortcomings.
Markus Armbruster [Sun, 26 Feb 2006 18:16:10 +0000 (18:16 +0000)]
(xdump): Nicer prompts.
Markus Armbruster [Sun, 26 Feb 2006 08:29:12 +0000 (08:29 +0000)]
(sources.mk): Avoid harmless circular dependency.
Markus Armbruster [Fri, 24 Feb 2006 21:35:27 +0000 (21:35 +0000)]
Update known contributors comment.
Markus Armbruster [Fri, 24 Feb 2006 21:23:46 +0000 (21:23 +0000)]
Boilerplate file comment.
Markus Armbruster [Fri, 24 Feb 2006 19:05:54 +0000 (19:05 +0000)]
(vers): Fix spacing.
Markus Armbruster [Fri, 24 Feb 2006 19:02:01 +0000 (19:02 +0000)]
(update_wantmin, update_policy_check, demand_check, upda): Remove the
ability to switch off demand updates by setting update_wantmin to
zero. Setting update_demandpolicy to UDDEM_DISABLE does the job.
(update_policy_check): Fix lower bound for blitz_time.
Markus Armbruster [Fri, 24 Feb 2006 18:33:58 +0000 (18:33 +0000)]
Rework obsolete comment on hours file, an move it where it belongs:
next to variable definitions and into econfig doc strings.
Markus Armbruster [Thu, 23 Feb 2006 18:34:42 +0000 (18:34 +0000)]
(vers): Clean up damage spill matrix.
(vers): Move show_custom() down somewhat.
(show_custom): Point players to show command.
Markus Armbruster [Thu, 23 Feb 2006 18:31:23 +0000 (18:31 +0000)]
(config_tables, custom_tables, read_config_tables, read_custom_tables)
(read_config_table_file, read_custom_table_file): Rename.
Markus Armbruster [Thu, 23 Feb 2006 08:37:46 +0000 (08:37 +0000)]
(EFF_CUSTOM): New.
(read_config_table_file): Set it.
(show_custom): Show it.
(vers): Use it.
Markus Armbruster [Thu, 23 Feb 2006 07:40:11 +0000 (07:40 +0000)]
(player_main): Don't end session silently when init_nats() fails.
Markus Armbruster [Thu, 23 Feb 2006 07:38:38 +0000 (07:38 +0000)]
(init_nats): Use CANT_HAPPEN() where appropriate.
Markus Armbruster [Thu, 23 Feb 2006 07:36:31 +0000 (07:36 +0000)]
Document not to edit this file to customize a game.
Markus Armbruster [Thu, 23 Feb 2006 07:32:41 +0000 (07:32 +0000)]
(show_opts): Revert rev. 1.13 `Pretend SHIPNAMES still exists...'
Clients had four months to adapt. Moreover, there have been other
changes that could well break clients, so backward compatibility is
gone anyway.
Markus Armbruster [Thu, 23 Feb 2006 07:23:52 +0000 (07:23 +0000)]
Document unused member.
Markus Armbruster [Thu, 23 Feb 2006 07:21:22 +0000 (07:21 +0000)]
Minor clarifications. Document play's use of C_EXIT for errors.
Markus Armbruster [Wed, 22 Feb 2006 22:12:18 +0000 (22:12 +0000)]
(banfil, authfil): Remove. Matching user is useless, because the
player can send whatever he wants. Banning IPs is better done with a
packet filter. That leaves restricting deity IPs.
(privip): New econfig key to restrict deity IPs.
(may_play): Implement it.
(match_user): Unused, remove.
Markus Armbruster [Wed, 22 Feb 2006 21:12:20 +0000 (21:12 +0000)]
Doc improvement.
Markus Armbruster [Wed, 22 Feb 2006 21:08:09 +0000 (21:08 +0000)]
(may_play): Clarify deity login rejection message.
Markus Armbruster [Wed, 22 Feb 2006 20:57:51 +0000 (20:57 +0000)]
(banfil, authfil): Remove. Matching user is useless, because the
player can send whatever he wants. Banning IPs is better done with a
packet filter. That leaves restricting deity IPs.
(privip): New econfig key to restrict deity IPs.
(may_play): Implement it.
(match_user): Unused, remove.