Semantics of assigning to $[ changed in Perl 5, and its use is `highly
discouraged'. Programs obviously assumed $[ affects all arrays, but
it doesn't in Perl 5. If these programs ever worked, then certainly
not with Perl 5. Remove the assignments and shift indexes
accordingly.
information on military. Closes#750533. Why? Wandering che pick a
sector with minimal military from the adjacent sectors that can get
che. Ties are broken in favour of the first sector examined. Since
sectors are examined in the order given by by diroff[], che prefer
directions with low index in diroff[]. This tends to channel che
towards the northeast. But the change makes ties very unlikely.
io_puts, iom_create, iom_getmask, iom_set, iom_clear, iom_zero):
Portability bug: io_select() passed bit_fdmask to select(). This
breaks the fd_set abstraction, and works only with the traditional
Unix implementation of fd_set. Use fd_set and its operations instead.
Remove unused source files. Note: the offending code is currently
unsued. But it's a time bomb, and fixing it also replaces a bunch of
code by standard library services.
breaks the fd_set abstraction, and works only with the traditional
Unix implementation of fd_set. Use fd_set and its operations instead.
Remove unused source files.
match info as well as related commands `sstat' and `pstat'. Rename
lstats() to lsta() to uphold the convention that functions
implementing commands are named like the command or its four character
prefix. Closes#804587.
that commands must be unique within the first four letters. best()
implements both. It calls BestDistPath() for the former, and
BestLandPath() for the latter. However, BestDistPath() is just a
wrapper around BestLandPath(); it does exactly the same. Drop
`bestdistpath'.
effect. Replace calls by struct assignment where possible. Replace
clear buffer, copy string to buffer by strncpy(). Use assignment to
clear when that's clearer. Replace overlapping copy through bounce
buffer by memmove(). Replace rest by standard memset() and memcpy().
Also use sizeof() instead of literal array sizes for robustness, and
instead of symbolic array sizes for clarity.
